Skip to content

Commit f5d6a55

Browse files
author
Daniel Herzog
committed
Additional fix for network-details search
1 parent a427a5b commit f5d6a55

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/network/network_view.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,18 @@ cls.NetworkLogView = function(id, name, container_class, html, default_handler)
5050
if (container)
5151
this._container = container;
5252

53-
// the query_selector for the mode needs to be set even when there is currently no query.
53+
// In details, it would be better to not have .network_info and headlines searchable, but those can
54+
// occur on different levels, so it's too complicated to do with the current script-search.
55+
// Also searching accross spans (for syntax highlighting) is more important.
5456
if (this.mode == DETAILS)
55-
this.text_search.set_query_selector(".entry-details > *:not(.network_info)");
57+
this.text_search.set_query_selector(".entry-details");
5658
else
5759
this.text_search.set_query_selector("[handler='select-network-request']");
5860

5961
var ctx = this._service.get_request_context();
6062
if (ctx)
6163
{
62-
// the filters need to be set when creating the view, the request_context may have changed in between
64+
// The filters need to be set when creating the view, the request_context may have changed in between
6365
ctx.set_filters(this._type_filters || []);
6466
this._render_main_view(this._container);
6567
this.text_search.update_search();

0 commit comments

Comments
 (0)