Skip to content

Commit f7c9ab0

Browse files
author
Daniel Herzog
committed
Review fixes
1 parent 25be86c commit f7c9ab0

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/ecma-debugger/runtimes.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1342,13 +1342,15 @@ cls.EcmascriptDebugger["6.0"].Runtimes = function(service_version)
13421342

13431343
this.reloadWindow = function(window_id)
13441344
{
1345-
__selected_window = window_id || __selected_window;
1346-
if (__selected_window)
1345+
if (!window_id)
1346+
window_id = __selected_window;
1347+
1348+
if (window_id)
13471349
{
1348-
if (!__windows_reloaded[__selected_window])
1349-
__windows_reloaded[__selected_window] = 1;
1350+
if (!__windows_reloaded[window_id])
1351+
__windows_reloaded[window_id] = 1;
13501352

1351-
var rt_id = this.getRuntimeIdsFromWindow(__selected_window)[0];
1353+
var rt_id = this.getRuntimeIdsFromWindow(window_id)[0];
13521354
if (window.services['ecmascript-debugger'] &&
13531355
window.services['ecmascript-debugger'].is_enabled &&
13541356
// For background processes we can not use the exec service.

src/network/network_service.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ cls.NetworkLoggerService = function()
224224
if (!this._current_context)
225225
return;
226226

227-
entry._called_get_body = true;
227+
entry.called_get_body = true;
228228
var contentmode = cls.ResourceUtil.mime_to_content_mode(entry.mime);
229229
var typecode = {datauri: 3, string: 1}[contentmode] || 1;
230230
var tag = window.tagManager.set_callback(this, this._handle_get_resource, [entry]);
@@ -590,10 +590,10 @@ cls.NetworkLoggerEntry = function(id, resource_id, document_id, context_starttim
590590
this.requests_responses = [];
591591
this.current_responsecode = null;
592592
this.error_in_current_response = false;
593+
this.called_get_body = false;
593594
this._current_request = null;
594595
this._current_response = null;
595596
this._set_is_finished_on_responsefinished = false;
596-
this._called_get_body = false;
597597
};
598598

599599
cls.NetworkLoggerEntryPrototype = function()
@@ -980,7 +980,7 @@ cls.NetworkLoggerEntryPrototype = function()
980980
// Decide if body should be fetched, for when content-tracking is off or it's a cached request.
981981
if (
982982
this.is_finished &&
983-
!this._called_get_body &&
983+
!this.called_get_body &&
984984
(!this._current_response || !this._current_response.responsebody) &&
985985
// When we have a response, but didn't see responsefinished, it means there's really no
986986
// responsebody. Don't attempt to fetch it.

0 commit comments

Comments
 (0)