Merged
Conversation
ohaiwalt
requested changes
Apr 22, 2019
| - name: sidekiq | ||
| image: operationcode/operationcode_backend:latest | ||
| command: ["sidekiq", "-C config/sidekiq.yml.erb"] | ||
| command: ["bundle", "exec", sidekiq", "-C config/sidekiq.yml.erb"] |
Member
There was a problem hiding this comment.
You're missing an opening quote on sidekiq.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to run bundle exec prior due to changes in how the BE runs now. Additionally the cfg doesn't exist. Unsure if we need to specify or add a config so removing for now.
This change is only required when we merge the rails upgrade. I don't know what will happen with the current version. We could try pushing this and then manually changing the image to the one that was broken last night. Then merging the reverted PR.