Skip to content

Pybot service#86

Merged
ohaiwalt merged 3 commits intomasterfrom
pybot_service
Apr 28, 2019
Merged

Pybot service#86
ohaiwalt merged 3 commits intomasterfrom
pybot_service

Conversation

@apex-omontgomery
Copy link
Member

Add's pybot service url to the pods using the expected values.

Will also need to figure out how to add the dns values for staging.

@ohaiwalt
Copy link
Member

Could you add comments on these with the repo link, or some additional information on what they are? I also need to do that for the dashboards record. It'll help when we go to determine whether a record is necessary any longer.

Comments can be added like so:

// single line comment

/*
multi
line
comment
*/

@ohaiwalt
Copy link
Member

Also, question: Does sidekiq need the Slack var?

@apex-omontgomery
Copy link
Member Author

What do you mean

@ohaiwalt
Copy link
Member

What do you mean

Is sidekiq sending messages to Slack? Curiosity question.

@apex-omontgomery
Copy link
Member Author

Currently sidekiq is supposed to send directly to slack api, in the near future it's going to go through our slack service (pybot) and at that point we can remove some of these slack credentials.

@ohaiwalt
Copy link
Member

Is this ready to go? If so, I can merge after a rebase.

@apex-omontgomery
Copy link
Member Author

No, I need the correct urls it should resolve to. That's on my list to get with allen. I'm not sure how ELB and how it's setup is going to affect this.

@apex-omontgomery
Copy link
Member Author

Not exactly ready to merge. I still don't know the correct urls for both staging and prod with the pybot instance. I'll try and update today.

@ohaiwalt ohaiwalt merged commit 9ca2cf4 into master Apr 28, 2019
@ohaiwalt ohaiwalt deleted the pybot_service branch April 28, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants