Update CSV WebhookDescription struct #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: It is currently not possible to specify a conversion webhook without specifying either a validating or mutating admission webhook. Additionally, it is not possible to define the targetPort of the service for webhooks Solution: Update the WebhookDescription.Type Enum to include ConversionWebhook and allow users to specify a TargetPort as well.
|
/lgtm |
|
/approve |
benluddy
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: It is currently not possible to specify a conversion webhook
without specifying either a validating or mutating admission webhook.
Additionally, it is not possible to define the targetPort of the service
for webhooks
Solution: Update the WebhookDescription.Type Enum to include
ConversionWebhook and allow users to specify a TargetPort as well.