test: use correct time unit for expectation timeout

Signed-off-by: David Sondermann <david.sondermann@hivemq.com>

Author: Donnerbart

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/expectation/ExpectationIT.java

@@ -15,6 +15,8 @@
  */
 package io.javaoperatorsdk.operator.baseapi.expectation;
 
+import java.time.Duration;
+
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
@@ -35,7 +37,7 @@ class ExpectationIT {
 
   @Test
   void testExpectation() {
-    extension.getReconcilerOfType(ExpectationReconciler.class).setTimeout(30000L);
+    extension.getReconcilerOfType(ExpectationReconciler.class).setTimeout(Duration.ofSeconds(30));
     var res = testResource();
     extension.create(res);
 
@@ -50,7 +52,7 @@ void testExpectation() {
 
   @Test
   void expectationTimeouts() {
-    extension.getReconcilerOfType(ExpectationReconciler.class).setTimeout(300L);
+    extension.getReconcilerOfType(ExpectationReconciler.class).setTimeout(Duration.ofMillis(300));
     var res = testResource();
     extension.create(res);
 

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/expectation/ExpectationReconciler.java

@@ -18,6 +18,7 @@
 import java.time.Duration;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
 
 import io.fabric8.kubernetes.api.model.ContainerBuilder;
 import io.fabric8.kubernetes.api.model.ContainerPortBuilder;
@@ -48,11 +49,11 @@ public class ExpectationReconciler implements Reconciler<ExpectationCustomResour
 
   private final ExpectationManager<ExpectationCustomResource> expectationManager =
       new ExpectationManager<>();
+  private final AtomicReference<Duration> timeoutRef =
+      new AtomicReference<>(Duration.ofSeconds(30));
 
-  private volatile Long timeout = 30000L;
-
-  public void setTimeout(Long timeout) {
-    this.timeout = timeout;
+  public void setTimeout(Duration timeout) {
+    timeoutRef.set(timeout);
   }
 
   @Override
@@ -74,7 +75,7 @@ public UpdateControl<ExpectationCustomResource> reconcile(
       createDeployment(primary, context);
       var set =
           expectationManager.checkAndSetExpectation(
-              primary, context, Duration.ofSeconds(timeout), deploymentReadyExpectation());
+              primary, context, timeoutRef.get(), deploymentReadyExpectation());
       if (set) {
         return UpdateControl.noUpdate();
       }