Skip to content

[NEXT] Fix rendering of placeholders in metrics table and add anchor for operator SDK metrics #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Donnerbart wants to merge 0 commits into from
Closed

[NEXT] Fix rendering of placeholders in metrics table and add anchor for operator SDK metrics #2581

Donnerbart wants to merge 0 commits into from

Conversation

@Donnerbart
Copy link
Contributor

@Donnerbart Donnerbart commented Nov 15, 2024

Fixes #2579

@metacosm
Copy link
Collaborator

metacosm commented Nov 15, 2024

Note that this would probably be picked up from main whenever we rebase next. Thank you in any case!

@Donnerbart
Copy link
Contributor Author

Donnerbart commented Nov 15, 2024

Note that this would probably be picked up from main whenever we rebase next. Thank you in any case!

Ah, I thought the next branch was more decoupled from main already. No worries, the website is already updated and fixed from main. Do whatever makes your life easier with this PR (close or merge).

@metacosm metacosm force-pushed the next branch 2 times, most recently from 64a51e5 to 9dd9e19 Compare November 20, 2024 17:08
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 20, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Donnerbart Donnerbart closed this Nov 22, 2024
@Donnerbart Donnerbart force-pushed the bugfix/2579-docs-fix-metrics-table/next branch from 9eed618 to 8991e26 Compare November 22, 2024 12:32
@Donnerbart Donnerbart deleted the bugfix/2579-docs-fix-metrics-table/next branch November 22, 2024 12:32
@Donnerbart
Copy link
Contributor Author

Donnerbart commented Nov 22, 2024

This change was picked up by the rebase of next with main. When re-creating the branch I got the expected "Nothing to cherry-pick". Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm metacosm approved these changes

@csviri csviri csviri approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Donnerbart @metacosm @openshift-merge-robot @csviri