Skip to content

Conversation

@shawkins
Copy link
Collaborator

@shawkins shawkins commented Oct 15, 2025

Pros:

  • no additional locking
  • could be adapted to not even rely on resourceVersion comparisons

Cons:

  • additional state accumulation on ResourceState during processing. This can be narrowed, but that could end up looking like similar to a locking based solution.
  • isNextReconciliationImminent is weakened - without further refinement we won't commit to dependent events triggering a next reconciliation until we're done with the current reconcilitation

Another thought - in what situations will dependents have multiple primary resources? We are skipping the reconciliation for all of them if canSkipEvent returns true from the temporary resource cache, but that add/update occurred for just a single primary resource.

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2025
@csviri
Copy link
Collaborator

csviri commented Oct 20, 2025

thank you will try to take a look soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants