Improve PodTemplateSpec sanitizer for GKE Autopilot compatibility #3012
Conversation
…herTest for better type safety Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
There was a problem hiding this comment.
Pull Request Overview
This PR improves the PodTemplateSpec sanitizer to handle GKE Autopilot environments, which automatically inject additional resource requirements like ephemeral-storage that may not be present in the desired state.
Key Changes:
- Removed the resource map size equality check that prevented sanitization when actual and desired resources had different numbers of entries
- Added test coverage for scenarios where additional resources (e.g., ephemeral-storage) are injected by external operators like GKE Autopilot
- Updated test type parameters for better type safety
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PodTemplateSpecSanitizer.java | Removed size mismatch filter to allow sanitization when actual resources contain additional entries injected by the platform |
| PodTemplateSpecSanitizerTest.java | Removed obsolete size mismatch test and added new tests covering GKE Autopilot scenarios with ephemeral-storage injection |
| SSABasedGenericKubernetesResourceMatcherTest.java | Improved type safety by adding explicit generic type parameters to test classes and builders |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| private static class ConfigMapDR extends KubernetesDependentResource<ConfigMap, ConfigMap> { | ||
| private static class ConfigMapDR extends KubernetesDependentResource<ConfigMap, HasMetadata> { |
There was a problem hiding this comment.
nit: What is the reason for this change?
There was a problem hiding this comment.
To make the existing field mockedContext re-useable without any casts or warnings.
I've changed the context from Context<?> to Context<HasMetadata>, which works for all existing tests. And then aligned ConfigMapDR to use HasMetadata as primary resource as well.
The whole test class is now warning free in my IDEA.
2 participants
Fixes #3006