-
Notifications
You must be signed in to change notification settings - Fork 68
🐛 Restore ManagedFields to operator-controller cache #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Restore ManagedFields to operator-controller cache #2318
Conversation
The Boxcutter library uses ManagedFields internally, so we need to keep them around, at least in operator-controller. Catalogd can still strip them from its cache. Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2318 +/- ##
==========================================
+ Coverage 71.14% 74.26% +3.11%
==========================================
Files 91 91
Lines 7046 7057 +11
==========================================
+ Hits 5013 5241 +228
+ Misses 1618 1402 -216
+ Partials 415 414 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oceanc80
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6beca87
into
operator-framework:main
The Boxcutter library uses ManagedFields internally, so we need to keep them around, at least in operator-controller. Catalogd can still strip them from its cache.
Description
Reviewer Checklist