Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 10, 2025

The Boxcutter library uses ManagedFields internally, so we need to keep them around, at least in operator-controller. Catalogd can still strip them from its cache.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

The Boxcutter library uses ManagedFields internally, so we need to keep them
around, at least in operator-controller. Catalogd can still strip them from
its cache.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner November 10, 2025 20:46
@openshift-ci openshift-ci bot requested review from anik120 and perdasilva November 10, 2025 20:46
@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6b927e9
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69124f10eb4cdc0008c955e6
😎 Deploy Preview https://deploy-preview-2318--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort tmshort requested a review from joelanford November 10, 2025 20:46
@perdasilva
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.26%. Comparing base (b3f85d5) to head (6b927e9).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/applier/boxcutter.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2318      +/-   ##
==========================================
+ Coverage   71.14%   74.26%   +3.11%     
==========================================
  Files          91       91              
  Lines        7046     7057      +11     
==========================================
+ Hits         5013     5241     +228     
+ Misses       1618     1402     -216     
+ Partials      415      414       -1     
Flag Coverage Δ
e2e 45.89% <50.00%> (-0.05%) ⬇️
experimental-e2e 48.25% <75.00%> (?)
unit 58.50% <12.50%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@oceanc80 oceanc80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6beca87 into operator-framework:main Nov 11, 2025
25 checks passed
@tmshort tmshort deleted the memory-improvements branch November 11, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants