-
Notifications
You must be signed in to change notification settings - Fork 68
🐛 Reduce log verbosity by moving BoxCutter reports to debug mode #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Reduce log verbosity by moving BoxCutter reports to debug mode #2335
Conversation
Detailed reconcile and teardown reports are now only logged when debug mode is enabled, preventing excessive log output.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reduces log verbosity by moving detailed BoxCutter reconcile and teardown reports to debug mode (V(1) log level). Previously, these reports were included directly in error logs, causing excessive output. Now the error message is logged at the default level, while the detailed report is only logged when debug mode is enabled.
- Split error logging from detailed report logging for reconcile and teardown operations
- Added explanatory comments for the debug logging pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2335 +/- ##
==========================================
- Coverage 74.30% 74.29% -0.01%
==========================================
Files 91 91
Lines 7083 7085 +2
==========================================
+ Hits 5263 5264 +1
- Misses 1405 1406 +1
Partials 415 415
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anik120
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override patch |
|
@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override codecov/patch |
|
@tmshort: Overrode contexts on behalf of tmshort: codecov/patch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1eb9b70
into
operator-framework:main
Detailed reconcile and teardown reports are now only logged when debug mode is enabled, preventing excessive log output.