Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Detailed reconcile and teardown reports are now only logged when debug mode is enabled, preventing excessive log output.

Detailed reconcile and teardown reports are now only logged when
debug mode is enabled, preventing excessive log output.
Copilot AI review requested due to automatic review settings November 17, 2025 12:58
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 17, 2025 12:58
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 64a759e
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/691b1c06e9183f0008bd27a2
😎 Deploy Preview https://deploy-preview-2335--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot finished reviewing on behalf of camilamacedo86 November 17, 2025 13:00
@camilamacedo86 camilamacedo86 changed the title Reduce log verbosity by moving BoxCutter reports to debug mode 🐛 Reduce log verbosity by moving BoxCutter reports to debug mode Nov 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces log verbosity by moving detailed BoxCutter reconcile and teardown reports to debug mode (V(1) log level). Previously, these reports were included directly in error logs, causing excessive output. Now the error message is logged at the default level, while the detailed report is only logged when debug mode is enabled.

  • Split error logging from detailed report logging for reconcile and teardown operations
  • Added explanatory comments for the debug logging pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.29%. Comparing base (c06f27f) to head (64a759e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...controllers/clusterextensionrevision_controller.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2335      +/-   ##
==========================================
- Coverage   74.30%   74.29%   -0.01%     
==========================================
  Files          91       91              
  Lines        7083     7085       +2     
==========================================
+ Hits         5263     5264       +1     
- Misses       1405     1406       +1     
  Partials      415      415              
Flag Coverage Δ
e2e 45.67% <0.00%> (+0.03%) ⬆️
experimental-e2e 48.39% <50.00%> (+<0.01%) ⬆️
unit 58.58% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@tmshort
Copy link
Contributor

tmshort commented Nov 17, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2025
@tmshort
Copy link
Contributor

tmshort commented Nov 17, 2025

/override patch

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • patch

Only the following failed contexts/checkruns were expected:

  • Autovalidate
  • Verify PR title
  • codecov/patch
  • crd-diff
  • e2e-kind
  • extension-developer-e2e
  • go-apidiff
  • go-verdiff
  • goreleaser
  • lint
  • netlify/olmv1/deploy-preview
  • tide
  • unit-test-basic
  • upgrade-e2e
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort
Copy link
Contributor

tmshort commented Nov 17, 2025

/override codecov/patch

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

@tmshort: Overrode contexts on behalf of tmshort: codecov/patch

In response to this:

/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 1eb9b70 into operator-framework:main Nov 17, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants