Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Steps Executed

  • with go 1.24.6
  • bingo get golangci-lint@none
  • bingo get github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

**Steps Executed**
- with go 1.24.6
- bingo get golangci-lint@none
- bingo get github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
Copilot AI review requested due to automatic review settings November 17, 2025 13:58
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 17, 2025 13:58
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a0e9c78
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/691b2acb2727ab00084de50f
😎 Deploy Preview https://deploy-preview-2336--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades golangci-lint from v2.1.6 to v2.6.2, which includes updates to numerous linter dependencies and improvements to the bingo build system.

Key Changes:

  • Upgraded golangci-lint from v2.1.6 to v2.6.2
  • Updated hundreds of linter dependencies to their latest versions
  • Enhanced bingo build system with cross-compilation support for host platform
  • Updated bingo tooling from v0.9 to v0.10

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.bingo/variables.env Updated golangci-lint version reference and bingo version to v0.10
.bingo/golangci-lint.sum Updated all transitive dependencies for golangci-lint v2.6.2
.bingo/golangci-lint.mod Updated golangci-lint version and Go version requirement
.bingo/Variables.mk Added GOHOSTOS/GOHOSTARCH/GOHOSTARM support for cross-compilation and updated version references
.bingo/README.md Improved documentation formatting and updated Go version requirements
.bingo/.gitignore Added *tmp.sum to ignore list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.30%. Comparing base (c06f27f) to head (a0e9c78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files          91       91           
  Lines        7083     7083           
=======================================
  Hits         5263     5263           
  Misses       1405     1405           
  Partials      415      415           
Flag Coverage Δ
e2e 45.75% <ø> (+0.10%) ⬆️
experimental-e2e 48.39% <ø> (ø)
unit 58.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit e20c9bc into operator-framework:main Nov 17, 2025
25 checks passed
@camilamacedo86 camilamacedo86 deleted the up-golint branch November 17, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants