Skip to content

🐛 Downgrade bingo output files to v0.9.0 #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

🐛 Downgrade bingo output files to v0.9.0 #2343

merged 1 commit into from
Nov 18, 2025

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 18, 2025

The latest bingo files were generated with bingo v0.10.0, which requires golang 1.24.9, which we don't support.

Downgrade the output files via bingo v0.9.0

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner November 18, 2025 14:50
@netlify
Copy link

netlify bot commented Nov 18, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e1dea12
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/691c9f8df422c70008b90c50
😎 Deploy Preview https://deploy-preview-2343--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

camilamacedo86
camilamacedo86 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
camilamacedo86
camilamacedo86 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.25%. Comparing base (697f392) to head (e1dea12).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2343       +/-   ##
===========================================
+ Coverage   55.97%   74.25%   +18.27%     
===========================================
  Files          82       91        +9     
  Lines        6547     7198      +651     
===========================================
+ Hits         3665     5345     +1680     
+ Misses       2367     1426      -941     
+ Partials      515      427       -88
Flag Coverage Δ
e2e 44.57% <ø> (+0.01%) ⬆️
experimental-e2e 48.51% <ø> (ø)
unit 58.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
camilamacedo86
camilamacedo86 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2025
@tmshort tmshort force-pushed the bingo-0.9.0 branch 5 times, most recently from d3cdfb3 to e2707cb Compare November 18, 2025 16:25
@tmshort
Downgrade bingo output files to v0.9.0
e1dea12 
The latest bingo files were generated with bingo v0.10.0, which requires
golang 1.24.9, which we don't support.

Downgrade the output files via bingo v0.9.0

Add test to ensure correct version of bingo is used.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Copy link
Contributor Author

tmshort commented Nov 18, 2025

@camilamacedo86 this is ready now... there was a timeout issue in bingo CI that was giving me a headache.

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Nov 18, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@perdasilva
Copy link
Contributor

perdasilva commented Nov 18, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6ef62de into operator-framework:main Nov 18, 2025
25 checks passed
@tmshort tmshort deleted the bingo-0.9.0 branch November 18, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@trgeiger trgeiger Awaiting requested review from trgeiger

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort @camilamacedo86 @perdasilva