🌱 Use local cache to check kind version #2346
Conversation
Use the local cached source of kind to determine the k8s version it supports. It avoids hitting github if possible. Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
github had issues yesterday; this avoids git hub when running kind locally. |
| # Get the version of the image from github | ||
| if [ -z "${KIND_VER}" ]; then | ||
| KIND_VER=$(curl -L -s https://github.com/kubernetes-sigs/kind/raw/refs/tags/${KIND}/pkg/apis/config/defaults/image.go | grep -Eo "${REGEX}") | ||
| fi |
There was a problem hiding this comment.
is there a situation when we cannot resolve KIND_VER from the local cache? Can we remove this actually?
There was a problem hiding this comment.
This is the original check that broke when github was down yesterday. It's possible someone may have cleaned up their local cache, so I'd rather just leave it as a "just-in-case".
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, pedjak, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 03eb884
into
operator-framework:main
4 participants
Use the local cached source of kind to determine the k8s version it supports. It avoids hitting github if possible.
Description
Reviewer Checklist