✨ Admission webhook to restrict usage of kapp-controller APIs #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
force-pushed
the
kapp-webhook
branch
6 times, most recently
from
27cdc1c to
a207d16
Compare
❌ Deploy Preview for olmv1 failed.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
- Coverage 64.01% 63.61% -0.40%
==========================================
Files 22 23 +1
Lines 1370 1399 +29
==========================================
+ Hits 877 890 +13
- Misses 442 457 +15
- Partials 51 52 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 2 commits
March 13, 2024 14:49
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Member
Author
|
We decided to not restrict use of Carvel APIs upstream for now. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are not prepared to support the full surface area of the Carvel APIs at the moment and want to put admission webhook in place to make it harder to use Carvel APIs directly when installed together with OLM.
The plan is to only accept create, update and delete operations from operator-controller and kapp-controller service accounts. This will apply to all resources in the following groups:
internal.packaging.carvel.devkappctrl.k14s.iopackaging.carvel.devReviewer Checklist