Skip to content

Conversation

@anik120
Copy link
Contributor

@anik120 anik120 commented Oct 22, 2025

Add /metrics nonResourceURL permission to allow Prometheus in OCP to access authenticated metrics without HTTP 500 errors.

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from dtfranz and tmshort October 22, 2025 20:54
@anik120
Copy link
Contributor Author

anik120 commented Oct 22, 2025

Fyi I've been trying to test this change downstream here, but getting an openshift cluster today has been a challenge (due to limited shared cluster availability)

@anik120
Copy link
Contributor Author

anik120 commented Oct 23, 2025

/hold

I have to fix something

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
Add additional permission to allow Prometheus in OCP
to access authenticated metrics without HTTP 500 errors.
@anik120 anik120 force-pushed the servicemonitor-rbac branch from fb9bf79 to c371878 Compare October 23, 2025 18:05
@anik120
Copy link
Contributor Author

anik120 commented Oct 23, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@anik120
Copy link
Contributor Author

anik120 commented Oct 23, 2025

Fyi for reviewers:

I've added another commit that skips the metrics e2e tests for now. They were using a very hacky (pod proxy) method to fetch the metrics, which doesn't work anymore in Openshift since the metrics endpoints are secure by default in Openshift.

I have to redesign the test suite structure to work with the authentication mechanism, which I plan on doing soon after as a follow up

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ca9fb30 into operator-framework:master Oct 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants