Skip to content

fix: Make cert-manager optional for secured metrics endpoints #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

fix: Make cert-manager optional for secured metrics endpoints #3706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ local-build: IMAGE_TAG = local
local-build: image

.PHONY: run-local
run-local: local-build kind-create cert-manager-install deploy
run-local: local-build kind-create deploy

.PHONY: cert-manager-install
cert-manager-install: #HELP Install cert-manager $(CERT_MANAGER_VERSION)
Expand Down Expand Up @@ -259,7 +259,6 @@ deploy: $(KIND) $(HELM) #HELP Deploy OLM to kind cluster $KIND_CLUSTER_NAME (def
$(KIND) load docker-image $(OLM_IMAGE) --name $(KIND_CLUSTER_NAME); \
$(HELM) upgrade --install olm deploy/chart \
--set debug=true \
--set certManager.enabled=true \
--set olm.image.ref=$(OLM_IMAGE) \
--set olm.image.pullPolicy=IfNotPresent \
--set catalog.image.ref=$(OLM_IMAGE) \
Expand All @@ -283,9 +282,6 @@ undeploy: $(KIND) $(HELM) #HELP Uninstall OLM from kind cluster $KIND_CLUSTER_NA
$(HELM) uninstall olm
kubectl delete -f deploy/chart/crds

# Uninstall cert-manager
$(MAKE) cert-manager-uninstall

#SECTION e2e

# E2E test configuration
Expand Down
2 changes: 1 addition & 1 deletion deploy/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ monitoring:
namespace: monitoring

certManager:
enabled: true
enabled: false
issuer:
name: olm-ca-issuer
selfSigned: true
Expand Down