Skip to content

Bug 1744314: Use 4.2 oauth-proxy image and support override image via envvar for ART OLM manifest manipulation #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2019
Merged

Bug 1744314: Use 4.2 oauth-proxy image and support override image via envvar for ART OLM manifest manipulation #911

merged 2 commits into from
Aug 26, 2019

Conversation

@chancez
Copy link
Contributor

@chancez chancez commented Aug 23, 2019

Chance Zibolski added 2 commits August 23, 2019 15:22
charts: Use 4.2 openshift oauth-proxy image
edae0cc
charts,manifests,images: Support setting oauth-proxy image via enviro…
e8c3f3e 
…nment variable

To allow the ART OLM manifest service to replace the oauth-proxy image
with the OCP image, we must be able to use an environment variable to
set it, and have it contained in our image-reference file.
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 23, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 23, 2019

@chancez: This pull request references Bugzilla bug 1744314, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1744314: Use 4.2 oauth-proxy image and support override image via envvar for ART OLM manifest manipulation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2019
@chancez
Copy link
Contributor Author

chancez commented Aug 23, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 23, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 23, 2019

@chancez: This pull request references Bugzilla bug 1744314, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan
timflannagan approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chancez, timflannagan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2e79cb7 into kube-reporting:master Aug 26, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2019

@chancez: All pull requests linked via external trackers have merged. Bugzilla bug 1744314 has been moved to the MODIFIED state.

In response to this:

Bug 1744314: Use 4.2 oauth-proxy image and support override image via envvar for ART OLM manifest manipulation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chancez chancez deleted the oauth_proxy_image_update branch August 26, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilyM1 EmilyM1 Awaiting requested review from EmilyM1

1 more reviewer

@timflannagan timflannagan timflannagan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timflannagan timflannagan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chancez @openshift-ci-robot @timflannagan @openshift-merge-robot