Skip to content

Conversation

@chancez
Copy link
Contributor

@chancez chancez commented Oct 16, 2019

This setting only affects new tables, so doing this shouldn't have any major
backwards compatible issues, as we shouldn't be assuming anything about the
table formats anyways, since it could be changed.

/hold
We will likely want to file a bug and backport to 4.2.1 so that new installs are more likely to get ORC for all new tables.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2019
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2019
@chancez
Copy link
Contributor Author

chancez commented Oct 16, 2019

/retest

2 similar comments
@chancez
Copy link
Contributor Author

chancez commented Oct 16, 2019

/retest

@chancez
Copy link
Contributor Author

chancez commented Oct 16, 2019

/retest

@chancez chancez changed the title Fix setting default fileformat for Hive tables bug 1763306: Fix setting default fileformat for Hive tables Oct 18, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 18, 2019
@openshift-ci-robot
Copy link

@chancez: This pull request references Bugzilla bug 1763306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bug 1763306: Fix setting default fileformat for Hive tables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chancez
Copy link
Contributor Author

chancez commented Oct 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2019
@chancez
Copy link
Contributor Author

chancez commented Oct 18, 2019

/cherry-pick release-4.2

@openshift-cherrypick-robot

@chancez: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@EmilyM1 EmilyM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chancez, EmilyM1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bad4a00 into kube-reporting:master Oct 18, 2019
@openshift-ci-robot
Copy link

@chancez: All pull requests linked via external trackers have merged. Bugzilla bug 1763306 has been moved to the MODIFIED state.

In response to this:

bug 1763306: Fix setting default fileformat for Hive tables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@chancez: new pull request created: #1000

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants