Skip to content

Conversation

@timflannagan
Copy link
Member

Signed-off-by: timflannagan timflannagan@gmail.com

Description of the change:
Update how CI tooling is installed in order to make it consistent across local and CI environments.

Motivation for the change:
Tech debt/cleanup.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from anik120 and grokspawn July 28, 2022 18:11
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan force-pushed the cleanup/refactor-tool-dependencies branch from daf870a to 21de304 Compare July 28, 2022 18:13
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1001 (21de304) into master (6ac352f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1001   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files         104      104           
  Lines        9468     9468           
=======================================
  Hits         5006     5006           
  Misses       3529     3529           
  Partials      933      933           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 732b572 into operator-framework:master Aug 3, 2022
@timflannagan timflannagan deleted the cleanup/refactor-tool-dependencies branch August 3, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants