Skip to content

Conversation

@timflannagan
Copy link
Member

Signed-off-by: timflannagan timflannagan@gmail.com

Description of the change:
Remove the unused 'retest' action as it doesn't play well with prow-enabled repositories, and it's largely unused in the day-to-day PR workflows.

Motivation for the change:
Tech debt/cleanup.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: timflannagan <timflannagan@gmail.com>
@openshift-ci openshift-ci bot requested review from ecordell and kevinrizza July 28, 2022 18:12
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1002 (430f834) into master (6ac352f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files         104      104           
  Lines        9468     9468           
=======================================
  Hits         5006     5006           
  Misses       3529     3529           
  Partials      933      933           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@grokspawn
Copy link
Contributor

Waited two weeks for a lgtm, and we have neither a hold or lgtm from tide-enumerated reviewers.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 33ed9ea into operator-framework:master Aug 8, 2022
@timflannagan timflannagan deleted the cleanup/remove-unused-action branch August 8, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants