Skip to content

examples for opm alpha render-graph to generate channel graph images #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 29, 2022
Merged

examples for opm alpha render-graph to generate channel graph images #1012

merged 4 commits into from
Aug 29, 2022

Conversation

@grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Aug 9, 2022 •
edited
Loading

Signed-off-by: Jordan Keister jordan@nimblewidget.com

Description of the change:
Adding examples of opm alpha render-graph so that we can provide examples of the more complex pipelines required to generate a picture of operator upgrade graphs.

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #1012 (f9023d9) into master (63c1932) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   51.67%   51.68%   +0.01%     
==========================================
  Files         102      102              
  Lines        9153     9153              
==========================================
+ Hits         4730     4731       +1     
+ Misses       3515     3514       -1     
  Partials      908      908
Impacted Files Coverage Δ
alpha/veneer/semver/semver.go 60.50% <0.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bentito
bentito reviewed Aug 23, 2022
View reviewed changes
bentito
bentito reviewed Aug 23, 2022
View reviewed changes
bentito
bentito reviewed Aug 23, 2022
View reviewed changes
cmd/opm/render/cmd.go Outdated
#
# Output declarative configuration view of a bundle-image in YAML format
#
$ opm render quay.io/operatorhubio/ack-apigatewayv2-controller@sha256:14c507f2ecb4a64928bcfcf5897f4495d9988f4d7ff58f41e029359a9fe78c38
Copy link
Contributor

@bentito bentito Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why one example is with SHA and one is with tag?

Copy link
Contributor Author

@grokspawn grokspawn Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is also an index image (tag) and the other is a bundle image (SHA). Just because that's the example I pulled from the existing catalog.

Copy link
Contributor

@bentito bentito Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable then

bentito
bentito reviewed Aug 23, 2022
View reviewed changes
bentito
bentito reviewed Aug 23, 2022
View reviewed changes
@grokspawn grokspawn removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@bentito
Copy link
Contributor

bentito commented Aug 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@grokspawn
Copy link
Contributor Author

grokspawn commented Aug 26, 2022

/hold
really want #1013 to close first, and rehash this as examples against the new command

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
@perdasilva
Copy link
Contributor

perdasilva commented Aug 29, 2022

/lgtm

@perdasilva
Copy link
Contributor

perdasilva commented Aug 29, 2022

/approved

@perdasilva
Copy link
Contributor

perdasilva commented Aug 29, 2022 •
edited
Loading

/hold cancel #1013 has been merged realised you want to rehash the examples

@perdasilva perdasilva added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 29, 2022
@grokspawn
examples for to generate channel graph images
f271fdf 
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn
added details for how to avoid mermaid's maxTextSize limits
9a64a7f 
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn
fixing comment
33e901a 
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn
revised for the new render-graph command
f9023d9 
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn grokspawn force-pushed the render-mermaid-examples branch from 689d167 to f9023d9 Compare August 29, 2022 16:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@grokspawn
Copy link
Contributor Author

grokspawn commented Aug 29, 2022

/hold cancel
re-worked the examples given the new context

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2022
@grokspawn grokspawn changed the title examples for opm render to generate channel graph images examples for opm alpha render-graph to generate channel graph images Aug 29, 2022
@bentito
Copy link
Contributor

bentito commented Aug 29, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7470c35 into master Aug 29, 2022
@grokspawn grokspawn deleted the render-mermaid-examples branch August 27, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentito bentito bentito left review comments

@benluddy benluddy Awaiting requested review from benluddy

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@perdasilva perdasilva

@bentito bentito

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grokspawn @bentito @perdasilva @openshift-merge-robot