Addressing additional feedback from PR 1015

[oceanc80]

Signed-off-by: Catherine Chan-Tse cchantse@redhat.com

Description of the change:
Addresses additional comments from #1015:

• moves semver command input handling logic out to a separate function
• renames readFile input argument to be more descriptive

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[codecov]

Codecov Report

Merging #1017 (76aa487) into master (52e35f0) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 76aa487 differs from pull request most recent head 51e4030. Consider uploading reports for the commit 51e4030 to get more accurate results

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   52.94%   52.95%   +0.01%     
==========================================
  Files         105      105              
  Lines        9612     9612              
==========================================
+ Hits         5089     5090       +1     
+ Misses       3568     3567       -1     
  Partials      955      955              

Impacted Files	Coverage Δ
alpha/veneer/semver/semver.go	60.50% <0.00%> (+0.50%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[grokspawn]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, oceanc80, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[timflannagan]

ah no approved-acts-as-lgtm enabled for this repository

/lgtm