Skip to content

Conversation

@grokspawn
Copy link
Contributor

Signed-off-by: Jordan Keister jordan@nimblewidget.com

Description of the change:
Add support for any action.Render target.

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from joelanford and njhale September 2, 2022 12:17
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1019 (c88de79) into master (ce3bb44) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c88de79 differs from pull request most recent head 8e928c7. Consider uploading reports for the commit 8e928c7 to get more accurate results

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
+ Coverage   51.66%   51.68%   +0.01%     
==========================================
  Files         102      102              
  Lines        9164     9164              
==========================================
+ Hits         4735     4736       +1     
+ Misses       3521     3520       -1     
  Partials      908      908              
Impacted Files Coverage Δ
alpha/veneer/semver/semver.go 60.50% <0.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn grokspawn force-pushed the render-graph-sqlite-support branch from 66a4acc to 8e928c7 Compare September 2, 2022 15:05
@grokspawn grokspawn changed the title opm alpha render-graph support all valid action.render targets opm alpha render-graph support all valid action.render targets with channels Sep 2, 2022
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bcdd689 into master Sep 2, 2022
@grokspawn grokspawn deleted the render-graph-sqlite-support branch September 2, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants