-
Notifications
You must be signed in to change notification settings - Fork 261
add skipRange support to render-graph #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
fe97e38 to
fff97c1
Compare
|
Thanks for doing this. I tried it out against one our packages: Question: This clearly shows the graph between bundles. Is there any thought of showing the upgrade graphs between channels, so one can see the intra-channel upgrade paths a bit more obviously? Maybe it would be a different render command, or it would get too busy? E.g. Make it obvious that you can move from any channel to the v2.0 channel. We have other examples, where one needs to traverse from v1.0 to v1.1 to v2.0 and directly from v1.0 to v2.0. |
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
+ Coverage 51.68% 51.84% +0.16%
==========================================
Files 102 102
Lines 9164 9181 +17
==========================================
+ Hits 4736 4760 +24
+ Misses 3520 3509 -11
- Partials 908 912 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'm abandoning this PR in favor of #1023. There started to be complex interactions between the different filtering options, and an increasing burden of sequencing the PRs was just more than I wanted to countenance. |
That is really cool! I hadn't really ever thought about inter-channel linkages before, honestly. It would definitely make the graph more noisy. I'll give it a look. |
|
The CNV folks have expressed a desire for inter-index graphs as well. That is, it would show the way to proceed when you move to another index. |
Signed-off-by: Jordan Keister jordan@nimblewidget.com
Description of the change:
mermaid output of channels will express skipRange relationships between nodes
Motivation for the change:
tired of the header/footer always expressing the feature's shortcomings ;)
Reviewer Checklist
/docs