Skip to content

Conversation

@joelanford
Copy link
Member

@joelanford joelanford commented Nov 22, 2022

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci openshift-ci bot requested review from jmrodri and njhale November 22, 2022 17:40
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1043 (e22a443) into master (6e014a3) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
+ Coverage   51.95%   52.05%   +0.09%     
==========================================
  Files         102      102              
  Lines        9215     9218       +3     
==========================================
+ Hits         4788     4798      +10     
+ Misses       3514     3506       -8     
- Partials      913      914       +1     
Impacted Files Coverage Δ
alpha/veneer/semver/semver.go 64.53% <100.00%> (+4.53%) ⬆️
pkg/registry/query.go 61.14% <0.00%> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem pretty straightforward to me, but due to my lack of contextual knowledge I will leave it to someone else to provide the LGTM.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0080ea0 into operator-framework:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants