Skip to content

Conversation

@joelanford
Copy link
Member

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Description of the change:
Update opm migrate help text to explain that json output format produces concatenated JSON

Motivation for the change:
Concatenated JSON may come as a surprise to users, because not all tools/libraries support it.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci openshift-ci bot requested review from benluddy and dinhxuanvu January 17, 2023 21:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #1055 (4500b04) into master (0080ea0) will increase coverage by 0.04%.
The diff coverage is 70.37%.

❗ Current head 4500b04 differs from pull request most recent head 08a7d9f. Consider uploading reports for the commit 08a7d9f to get more accurate results

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
+ Coverage   52.06%   52.10%   +0.04%     
==========================================
  Files         102      102              
  Lines        9218     9244      +26     
==========================================
+ Hits         4799     4817      +18     
- Misses       3505     3513       +8     
  Partials      914      914              
Impacted Files Coverage Δ
alpha/declcfg/load.go 76.52% <70.37%> (-2.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@everettraven
Copy link
Contributor

/lgtm-remove

(didn't think it would still add the LGTM label even though I am not in the OWNERS file)

@openshift-merge-robot openshift-merge-robot merged commit b7307b5 into operator-framework:master Jan 20, 2023
@everettraven
Copy link
Contributor

/lgtm cancel

@everettraven
Copy link
Contributor

Whoops ... I didn't mean to make it auto-merge and was too late with the cancel command it seems. At least this was a minor update 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants