Skip to content

Conversation

@grokspawn
Copy link
Contributor

Description of the change:
Updated asciinema demos for semver, using the y-streams for minor channels from previous PR, but also the veneer --> template rename.

Motivation for the change:
Accidental early merge of previous PR.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@openshift-ci openshift-ci bot requested review from benluddy and everettraven March 3, 2023 17:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1076 (f455fba) into master (6b1b166) will not change coverage.
The diff coverage is n/a.

❗ Current head f455fba differs from pull request most recent head 6fa4db3. Consider uploading reports for the commit 6fa4db3 to get more accurate results

@@           Coverage Diff           @@
##           master    #1076   +/-   ##
=======================================
  Coverage   52.78%   52.78%           
=======================================
  Files         107      107           
  Lines        9381     9381           
=======================================
  Hits         4952     4952           
  Misses       3512     3512           
  Partials      917      917           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@grokspawn
Copy link
Contributor Author

/ltgm

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@everettraven
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3094ce7 into operator-framework:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants