Skip to content

Conversation

@theishshah
Copy link
Contributor

Contains implementation changes, needs utest and documentation updates.

Ish Shah added 2 commits March 22, 2023 12:18
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1079 (54e84c0) into master (fcb9eb3) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 54e84c0 differs from pull request most recent head 4a2cf85. Consider uploading reports for the commit 4a2cf85 to get more accurate results

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
- Coverage   52.60%   52.58%   -0.02%     
==========================================
  Files         107      107              
  Lines        9384     9384              
==========================================
- Hits         4936     4935       -1     
- Misses       3521     3522       +1     
  Partials      927      927              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this implementation looks good to me. Just had a minor nit.

Would definitely like to see the unit tests updated to reflect this change and have a test in place for using a URL instead of a local path

Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
@grokspawn
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, theishshah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 49eae7b into operator-framework:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants