-
Notifications
You must be signed in to change notification settings - Fork 261
Add Support for Fetching Remote Catalog #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Fetching Remote Catalog #1079
Conversation
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
- Coverage 52.60% 52.58% -0.02%
==========================================
Files 107 107
Lines 9384 9384
==========================================
- Hits 4936 4935 -1
- Misses 3521 3522 +1
Partials 927 927 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this implementation looks good to me. Just had a minor nit.
Would definitely like to see the unit tests updated to reflect this change and have a test in place for using a URL instead of a local path
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
|
/approve |
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, grokspawn, theishshah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contains implementation changes, needs utest and documentation updates.