Skip to content

feat(release): X.Y, X, and latest opm image tags #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

feat(release): X.Y, X, and latest opm image tags #738

merged 1 commit into from
Aug 11, 2021

Conversation

@estroz
Copy link
Member

@estroz estroz commented Aug 4, 2021

Description of the change: build X.Y, X, and latest opm images but only latest if X.Y.Z is latest semver in HEAD.

Motivation for the change: quay.io/operator-framework/opm image consumers should be able to subscribe to patch releases automatically via X.Y tags, and to X/latest tags for the latest opm features.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from dinhxuanvu and joelanford August 4, 2021 23:16
@codecov
Copy link

codecov bot commented Aug 4, 2021 •
edited
Loading

Codecov Report

Merging #738 (080c9e4) into master (9b0c99a) will not change coverage.
The diff coverage is n/a.

❗ Current head 080c9e4 differs from pull request most recent head f0e20c2. Consider uploading reports for the commit f0e20c2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   50.19%   50.19%           
=======================================
  Files         100      100           
  Lines        8531     8531           
=======================================
  Hits         4282     4282           
  Misses       3421     3421           
  Partials      828      828

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0c99a...f0e20c2. Read the comment docs.

joelanford
joelanford reviewed Aug 5, 2021
View reviewed changes
@estroz estroz force-pushed the feat/more-opm-image-tags branch from 1e22970 to 4d39712 Compare August 5, 2021 20:43
@estroz estroz requested a review from joelanford August 5, 2021 20:46
@estroz
feat(release): X.Y, X, and latest opm image tags
f0e20c2 
build X.Y, X, and latest opm images
but only latest if X.Y.Z is latest semver in HEAD
and X.Y/X if the current HEAD commit is tagged.

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@estroz estroz force-pushed the feat/more-opm-image-tags branch from 4d39712 to f0e20c2 Compare August 5, 2021 20:52
joelanford
joelanford approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
njhale
njhale approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

.goreleaser.yaml
- "{{ .Env.OPM_IMAGE_REPO }}:{{ .Env.IMAGE_TAG }}-s390x"
# Release image builds will be skipped if *_IMAGE_OR_EMPTY variables are empty.
# https://github.com/goreleaser/goreleaser/blob/9ed3c0c/internal/pipe/docker/manifest.go#L105
- name_template: "{{ .Env.MAJ_MIN_IMAGE_OR_EMPTY }}"
Copy link
Member

@njhale njhale Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: IMO the comment is sufficient and this would read better without the suffix

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, joelanford, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@openshift-ci openshift-ci bot merged commit 6f1a54f into operator-framework:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford joelanford approved these changes

@njhale njhale njhale approved these changes

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees

@joelanford joelanford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@estroz @joelanford @njhale