opm validate: check for cycles and stranded bundles in channel validation #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 50.29% 50.41% +0.11%
==========================================
Files 101 101
Lines 8699 8720 +21
==========================================
+ Hits 4375 4396 +21
Misses 3471 3471
Partials 853 853
Continue to review full report at Codecov.
|
joelanford
force-pushed
the
dc-validate-cycles
branch
from
9e79e48 to
252e049
Compare
joelanford
changed the title
joelanford
changed the title
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
dc-validate-cycles
branch
from
252e049 to
0430fca
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Lanford joe.lanford@gmail.com
Description of the change:
This PR adds an additional validation check on indexes that verifies that no cycles are present in the replaces chain of a channel's upgrade graph. It also verifies that there are no stranded bundles.
Motivation for the change:
Cycles in the replaces chain of a channel's upgrade graph and stranded bundles are invalid.
Reviewer Checklist
/docs