-
Notifications
You must be signed in to change notification settings - Fork 261
Fix case-related typo in ConsoleYAMLSample entry in supported_resources #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andykrohg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @andykrohg. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=======================================
Coverage 50.24% 50.24%
=======================================
Files 101 101
Lines 8691 8691
=======================================
Hits 4367 4367
Misses 3471 3471
Partials 853 853
Continue to review full report at Codecov.
|
|
@andykrohg: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is a dupe of #694, which has also now been rebased :) |
|
Closing in favor of #694 |
Description of the change:
Fix a typo in the
ConsoleYAMLSamplekind in supported_resources. Runningoperator-sdk bundle validatewithConsoleYAMLSampleresources in the bundle'smanifestsdirectory givesERRO[0000] Error: Value console.openshift.io/v1, Kind=ConsoleYAMLSample: unsupported media type registry+v1 for bundle object, whereas the currentsupported_resources.golist of allowedkindscontainsConsoleYamlSample, so this validation is case-sensitive.Motivation for the change:
Allow the inclusion of
ConsoleYAMLSampleobjects in a operator bundles.Reviewer Checklist
/docs