Skip to content

Conversation

@andykrohg
Copy link

Description of the change:
Fix a typo in the ConsoleYAMLSample kind in supported_resources. Running operator-sdk bundle validate with ConsoleYAMLSample resources in the bundle's manifests directory gives ERRO[0000] Error: Value console.openshift.io/v1, Kind=ConsoleYAMLSample: unsupported media type registry+v1 for bundle object, whereas the current supported_resources.go list of allowed kinds contains ConsoleYamlSample, so this validation is case-sensitive.

Motivation for the change:
Allow the inclusion of ConsoleYAMLSample objects in a operator bundles.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andykrohg
To complete the pull request process, please assign ecordell after the PR has been reviewed.
You can assign the PR to them by writing /assign @ecordell in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from anik120 and dinhxuanvu August 18, 2021 21:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

Hi @andykrohg. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2021
@ankitathomas
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2021
@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #757 (10641ee) into master (9960109) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   50.24%   50.24%           
=======================================
  Files         101      101           
  Lines        8691     8691           
=======================================
  Hits         4367     4367           
  Misses       3471     3471           
  Partials      853      853           
Impacted Files Coverage Δ
pkg/lib/bundle/supported_resources.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9960109...10641ee. Read the comment docs.

@timflannagan timflannagan mentioned this pull request Aug 31, 2021
5 tasks
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@andykrohg: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jamstah
Copy link
Contributor

Jamstah commented Sep 1, 2021

This is a dupe of #694, which has also now been rebased :)

@andykrohg
Copy link
Author

Closing in favor of #694

@andykrohg andykrohg closed this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants