-
Notifications
You must be signed in to change notification settings - Fork 261
Add deprecation warnings for CLIs that use or depend on sqlite #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warnings for CLIs that use or depend on sqlite #760
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
==========================================
+ Coverage 50.29% 50.41% +0.12%
==========================================
Files 101 102 +1
Lines 8699 8725 +26
==========================================
+ Hits 4375 4399 +24
- Misses 3471 3473 +2
Partials 853 853
Continue to review full report at Codecov.
|
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
28cc5db to
3e62f83
Compare
|
/hold cancel I removed the link to docs from the deprecation message so that this deprecation logging is not blocked on the existence of docs. Once docs are updated, we can revisit this deprecation message and potentially opt to add a doc link at that time. |
|
/lgtm |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
9f6b255 to
8687b46
Compare
|
/lgtm |
Signed-off-by: Joe Lanford joe.lanford@gmail.com
Description of the change:
Add logging to all CLIs that use or depend on sqlite to note that sqlite-based catalogs are deprecated
Motivation for the change:
See https://github.com/operator-framework/enhancements/blob/master/enhancements/declarative-index-config.md#deprecations
For follow-up:
Add doc link to deprecation message when docs PR merges: operator-framework/olm-docs#177
Related PR for
oc: openshift/oc#908Reviewer Checklist
/docs