Skip to content

Conversation

@joelanford
Copy link
Member

@joelanford joelanford commented Aug 19, 2021

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Description of the change:
Add logging to all CLIs that use or depend on sqlite to note that sqlite-based catalogs are deprecated

Motivation for the change:
See https://github.com/operator-framework/enhancements/blob/master/enhancements/declarative-index-config.md#deprecations

For follow-up:
Add doc link to deprecation message when docs PR merges: operator-framework/olm-docs#177

Related PR for oc: openshift/oc#908

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@openshift-ci openshift-ci bot requested review from kevinrizza and njhale August 19, 2021 21:06
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #760 (8687b46) into master (a0bb1e5) will increase coverage by 0.12%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   50.29%   50.41%   +0.12%     
==========================================
  Files         101      102       +1     
  Lines        8699     8725      +26     
==========================================
+ Hits         4375     4399      +24     
- Misses       3471     3473       +2     
  Partials      853      853              
Impacted Files Coverage Δ
pkg/sqlite/deprecationmessage.go 0.00% <0.00%> (ø)
alpha/action/render.go 61.62% <100.00%> (+0.68%) ⬆️
alpha/model/model.go 92.64% <0.00%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0bb1e5...8687b46. Read the comment docs.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
Copy link
Member Author

/hold cancel

I removed the link to docs from the deprecation message so that this deprecation logging is not blocked on the existence of docs. Once docs are updated, we can revisit this deprecation message and potentially opt to add a doc link at that time.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
@joelanford joelanford merged commit 9bf77cf into operator-framework:master Aug 25, 2021
@joelanford joelanford deleted the deprecate-sqlite branch August 25, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants