Skip to content

Conversation

@estroz
Copy link
Member

@estroz estroz commented Sep 8, 2021

Description of the change: upgrade goreleaser to 0.177

Motivation for the change: checksum file name changed so the most recent install script is broken. Not sure how to pin the install script url to a version so this fix will work until their script breaks again ☹️.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

…file

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #773 (c178b3b) into master (59d0ec7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   50.62%   50.62%           
=======================================
  Files         101      101           
  Lines        8691     8691           
=======================================
  Hits         4400     4400           
  Misses       3454     3454           
  Partials      837      837           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d0ec7...c178b3b. Read the comment docs.

@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@joelanford
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1c85576 into operator-framework:master Sep 8, 2021
@estroz estroz deleted the fix/goreleaser-checksums-path branch September 8, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants