Skip to content

add warning log entry for removing non-exist package #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022
Merged

add warning log entry for removing non-exist package #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/sqlite/load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,9 @@ func (s *sqlLoader) RemovePackage(packageName string) error {
if err != nil {
return err
}
if len(csvNames) == 0 {
return fmt.Errorf("no package found for packagename %s", packageName)
}
for _, csvName := range csvNames {
if err := s.rmBundle(tx, csvName); err != nil {
return err
Expand Down
4 changes: 4 additions & 0 deletions pkg/sqlite/remove_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ func TestRemover(t *testing.T) {
_, err = query.GetPackage(context.TODO(), "prometheus")
require.EqualError(t, err, "package prometheus not found")

// delete prometheus again
err = store.RemovePackage("prometheus")
require.EqualError(t, err, "no package found for packagename prometheus")

// no apis after all packages are removed
rows, err = db.QueryContext(context.TODO(), "select * from api")
require.NoError(t, err)
Expand Down