-
Notifications
You must be signed in to change notification settings - Fork 261
opm serve: pre-compute and store api.Bundles to disk; requests read from disk #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opm serve: pre-compute and store api.Bundles to disk; requests read from disk #783
Conversation
…when serving Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6304be1 to
d490d74
Compare
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
+ Coverage 50.64% 50.65% +0.01%
==========================================
Files 102 102
Lines 8846 8879 +33
==========================================
+ Hits 4480 4498 +18
- Misses 3522 3530 +8
- Partials 844 851 +7
Continue to review full report at Codecov.
|
anik120
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rom disk (operator-framework#783) * opm serve: pre-compute and store api.Bundles to disk; read from disk when serving Signed-off-by: Joe Lanford <joe.lanford@gmail.com> * fix tests Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Joe Lanford joe.lanford@gmail.com
Description of the change:
When serving the registry from the model, pre-compute the
api.Bundleblobs, save them to disk, and reduce the size of the in-memory model to contain only enough to answer requests by looking up and reading bundles from disk.Motivation for the change:
This change provides a major memory optimization. Using a real-world file-based catalog (created by migrating a production sqlite-based catalog), the steady state RSS is reduced from 373Mb to 55Mb, an 85% decrease.
Reviewer Checklist
/docs