-
Notifications
You must be signed in to change notification settings - Fork 261
e2e local test for mac #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e local test for mac #785
Conversation
|
Hi @akihikokuroda. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
=======================================
Coverage 51.20% 51.20%
=======================================
Files 103 103
Lines 9077 9077
=======================================
Hits 4648 4648
Misses 3550 3550
Partials 879 879 Continue to review full report at Codecov.
|
|
I don't understand the go-apidiff / go-apidiff failure. Should I rebase? |
Yes, please! It looks like those failures are unrelated to your PR. |
f607622 to
78916f0
Compare
|
This looks good for me to lgtm but it should be squashed down to just one commit with the code change. Maybe just cherry-pick the latest commit onto the HEAD of latest master. |
|
@exdx We updated tide for this repository (and OLM) to automatically squash merge everything unless specified otherwise. |
|
Oh, sorry I misunderstood what you meant - it looks like we're pulling in unrelated changes in this PR? |
78916f0 to
14e1a5b
Compare
Signed-off-by: akihikokuroda <akuroda@us.ibm.com>
14e1a5b to
cc2659e
Compare
|
I've just rebased instead of merging from master. Thanks! |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akihikokuroda, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com
Description of the change:
For e2e local test,
make buildbuilds linux binaries by addingGOENV='GOOS=linux'in the command.Motivation for the change:
Closes #784
Reviewer Checklist
/docs