Skip to content

Conversation

@akihikokuroda
Copy link
Member

Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com

Description of the change:
For e2e local test, make build builds linux binaries by adding GOENV='GOOS=linux' in the command.

Motivation for the change:
Closes #784
Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from hasbro17 and njhale September 22, 2021 16:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2021
@dinhxuanvu
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2021
@dinhxuanvu dinhxuanvu requested a review from exdx September 30, 2021 14:40
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #785 (cc2659e) into master (829551e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   51.20%   51.20%           
=======================================
  Files         103      103           
  Lines        9077     9077           
=======================================
  Hits         4648     4648           
  Misses       3550     3550           
  Partials      879      879           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829551e...cc2659e. Read the comment docs.

@akihikokuroda
Copy link
Member Author

I don't understand the go-apidiff / go-apidiff failure. Should I rebase?

@joelanford
Copy link
Member

I don't understand the go-apidiff / go-apidiff failure. Should I rebase?

Yes, please! It looks like those failures are unrelated to your PR.

@exdx
Copy link
Contributor

exdx commented Sep 30, 2021

This looks good for me to lgtm but it should be squashed down to just one commit with the code change. Maybe just cherry-pick the latest commit onto the HEAD of latest master.

@timflannagan
Copy link
Member

@exdx We updated tide for this repository (and OLM) to automatically squash merge everything unless specified otherwise.

@timflannagan
Copy link
Member

Oh, sorry I misunderstood what you meant - it looks like we're pulling in unrelated changes in this PR?

Signed-off-by: akihikokuroda <akuroda@us.ibm.com>
@akihikokuroda
Copy link
Member Author

akihikokuroda commented Sep 30, 2021

I've just rebased instead of merging from master. Thanks!

@exdx
Copy link
Contributor

exdx commented Sep 30, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
@njhale
Copy link
Member

njhale commented Oct 11, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8179168 into operator-framework:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to run e2e locally on Mac: exec format error

7 participants