Skip to content

Conversation

@joelanford
Copy link
Member

Description of the change:

  • Updates release documentation to provide explicit commands to run to create appropriate tag.
  • Updates the Makefile to be more resilient to non-annotated tags.

Motivation for the change:
When we pushed the v1.18.1 tag, the v1 and v1.18 image tags were not pushed as expected. It seems like this happened because:

  1. v1.18.1 was not an annotated tag.
  2. The Makefile's use of a git describe command to check the tag of HEAD assumed only annotated tags.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from ecordell and exdx October 1, 2021 13:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #801 (8eb37f1) into master (37551d4) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   51.18%   51.20%   +0.01%     
==========================================
  Files         103      103              
  Lines        9078     9077       -1     
==========================================
+ Hits         4647     4648       +1     
+ Misses       3551     3550       -1     
+ Partials      880      879       -1     
Impacted Files Coverage Δ
alpha/action/render.go 63.87% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37551d4...8eb37f1. Read the comment docs.

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5ac5c52 into operator-framework:master Oct 1, 2021
@joelanford joelanford deleted the fix/docker-tags branch November 16, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants