Skip to content

goreleaser: use netgo and osusergo to ensure completely static binary builds #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021
Merged

goreleaser: use netgo and osusergo to ensure completely static binary builds #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ builds:
- CGO_ENABLED=1
mod_timestamp: "{{ .CommitTimestamp }}"
flags: &build-flags
- -tags=json1
- -tags=json1,netgo,osusergo
Copy link
Member

@timflannagan timflannagan Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if I squint I can see why osusergo is needed but it's not immediately obvious outside of opm's general domain what command is triggering the need for that tag.

/lgtm

Copy link
Member Author

@joelanford joelanford Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

I'm not positive if osusergo is actually necessary, but since we don't have anything that actually tests the results of our binary builds, I figured it was best to err on the side of caution.

asmflags: &build-asmflags
- all=-trimpath={{ .Env.PWD }}
gcflags: &build-gcflags
Expand Down