opm validate: fail on duplicate packages, channels, and bundles

[joelanford]

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Description of the change:
When opm validate (or any code that requires a file-based catalog to be converted to the registry's internal model) encounters a duplicate blob olm.package, olm.channel, or olm.bundle blob, emit an error.

Motivation for the change:
To prevent ambiguity in the way a file-based catalog is presented to consumers when there are duplicates. FBC is declarative, so it doesn't make sense to attempt to declare the same thing twice.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #824 (271fbf2) into master (7c8187a) will increase coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
+ Coverage   50.93%   51.46%   +0.52%     
==========================================
  Files         103      103              
  Lines        9001     9032      +31     
==========================================
+ Hits         4585     4648      +63     
+ Misses       3552     3510      -42     
- Partials      864      874      +10     

Impacted Files	Coverage Δ
alpha/declcfg/declcfg_to_model.go	93.06% <100.00%> (+0.93%)	⬆️
alpha/declcfg/diff.go	77.48% <0.00%> (+0.02%)	⬆️
alpha/action/diff.go	77.04% <0.00%> (+0.38%)	⬆️
pkg/registry/query.go	60.93% <0.00%> (+0.52%)	⬆️
alpha/declcfg/diff_include.go	61.32% <0.00%> (+33.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8187a...271fbf2. Read the comment docs.

[estroz]

/lgtm

[estroz]

This will need backporting correct?