Skip to content

Clean indexfile for opm alpha generate dockerfile #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

Clean indexfile for opm alpha generate dockerfile #831

merged 1 commit into from
Nov 30, 2021

Conversation

@ankitathomas
Copy link
Contributor

@ankitathomas ankitathomas commented Nov 18, 2021

drop trailing slash for catalog directory on opm alpha generate dockerfile to avoid / in the generated Dockerfile name

Closes #830

@openshift-ci openshift-ci bot requested review from ecordell and estroz November 18, 2021 21:32
@codecov
Copy link

codecov bot commented Nov 18, 2021 •
edited
Loading

Codecov Report

Merging #831 (10082f8) into master (f478fdd) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   52.06%   52.07%   +0.01%     
==========================================
  Files         103      103              
  Lines        9063     9063              
==========================================
+ Hits         4719     4720       +1     
+ Misses       3439     3438       -1     
  Partials      905      905
Impacted Files Coverage Δ
pkg/registry/query.go 60.93% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f478fdd...10082f8. Read the comment docs.

joelanford
joelanford reviewed Nov 18, 2021
View reviewed changes
cmd/opm/alpha/generate/cmd.go Outdated
}

dir, indexName := filepath.Split(fromDir)
indexName = filepath.Clean(indexName)
Copy link
Member

@joelanford joelanford Nov 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it also work to filepath.Clean(fromDir) at the very beginning? It seems like that could help us avoid future regressions if we later make other manipulations based on fromDir.

@ankitathomas ankitathomas force-pushed the clean-generate-dockerfile branch from f3ea6fb to d2e4cb2 Compare November 24, 2021 19:08
@perdasilva
Copy link
Contributor

perdasilva commented Nov 29, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@joelanford
Copy link
Member

joelanford commented Nov 29, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@joelanford
Copy link
Member

joelanford commented Nov 29, 2021

/hold
For DCO

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2021
@ankitathomas
drop trailing slash for catalog directory on opm alpha generate docke…
10082f8 
…rfile

Signed-off-by: Ankita Thomas <ankithom@redhat.com>
@ankitathomas ankitathomas force-pushed the clean-generate-dockerfile branch from d2e4cb2 to 10082f8 Compare November 30, 2021 14:04
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@joelanford
Copy link
Member

joelanford commented Nov 30, 2021

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8e4557f into operator-framework:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford joelanford left review comments

@ecordell ecordell Awaiting requested review from ecordell

@estroz estroz Awaiting requested review from estroz

Assignees

@joelanford joelanford

@perdasilva perdasilva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opm alpha generate dockerfile does not work when directory trailing slash is informed

5 participants

@ankitathomas @perdasilva @joelanford @openshift-bot @openshift-merge-robot