Skip to content

Conversation

@Shivkumar13
Copy link
Contributor

Description of the change: Updated extract.go, got my eyes on this while reading the code.

Motivation for the change: Updating to have a good reading experience.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • [ x] Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

@Shivkumar13: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Update extract.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

Hi @Shivkumar13. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for catching that typo. Please sign your commit:

git commit --amend --no-edit --signoff
git push --force-with-lease origin patch-3

@gallettilance
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2021
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@timflannagan
Copy link
Member

@Shivkumar13 It looks like the DCO check still is failing. Lance had posted a comment about how to make the DCO bot happy in #876 (review).

Updating for reader experience.

Signed-off-by: Shivkumar13 <shivkumar.ople97@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 25, 2021
@timflannagan
Copy link
Member

Recycling this PR as there are some prow checks that are showing up in the status for whatever reason.

/lgtm

@timflannagan timflannagan reopened this Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@Shivkumar13: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Update extract.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Member

Oh, there are prow jobs defined as this PR is targeting the release-4.8 branch. This branch no longer builds downstream, so it's technically a no-op, and I don't think we have any real appetite for backporting these changes to the 4.8 release.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #876 (42e5375) into master (a1fc9d0) will increase coverage by 4.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
+ Coverage   48.80%   53.04%   +4.24%     
==========================================
  Files          90      125      +35     
  Lines        6276    11133    +4857     
==========================================
+ Hits         3063     5906    +2843     
- Misses       2528     4154    +1626     
- Partials      685     1073     +388     
Impacted Files Coverage Δ
pkg/sqlite/db_options.go 40.00% <0.00%> (-10.00%) ⬇️
pkg/registry/csv.go 79.81% <0.00%> (-2.30%) ⬇️
pkg/registry/imageinput.go 69.23% <0.00%> (-0.27%) ⬇️
pkg/registry/empty.go 0.00% <0.00%> (ø)
pkg/sqlite/deprecate.go 0.00% <0.00%> (ø)
pkg/lib/bundle/supported_resources.go 100.00% <0.00%> (ø)
alpha/property/property.go 97.43% <0.00%> (ø)
pkg/lib/registry/interfaces.go 0.00% <0.00%> (ø)
alpha/action/generate_dockerfile.go 81.81% <0.00%> (ø)
pkg/lib/semver/semver.go 73.91% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fc9d0...42e5375. Read the comment docs.

@joelanford
Copy link
Member

It looks like this typo exists on master, so I'll retarget the PR for the master branch.

@joelanford joelanford changed the base branch from release-4.8 to master January 5, 2022 21:39
@joelanford joelanford closed this Jan 5, 2022
@joelanford joelanford reopened this Jan 5, 2022
@joelanford
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, gallettilance, joelanford, Shivkumar13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit 611525b into operator-framework:master Jan 5, 2022
@Shivkumar13 Shivkumar13 deleted the patch-3 branch January 13, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants