-
Notifications
You must be signed in to change notification settings - Fork 261
Update extract.go #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extract.go #876
Conversation
|
@Shivkumar13: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @Shivkumar13. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks for catching that typo. Please sign your commit:
git commit --amend --no-edit --signoff
git push --force-with-lease origin patch-3
|
/ok-to-test |
ankitathomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@Shivkumar13 It looks like the DCO check still is failing. Lance had posted a comment about how to make the DCO bot happy in #876 (review). |
Updating for reader experience. Signed-off-by: Shivkumar13 <shivkumar.ople97@gmail.com>
|
Recycling this PR as there are some prow checks that are showing up in the status for whatever reason. /lgtm |
|
@Shivkumar13: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Oh, there are prow jobs defined as this PR is targeting the release-4.8 branch. This branch no longer builds downstream, so it's technically a no-op, and I don't think we have any real appetite for backporting these changes to the 4.8 release. |
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
==========================================
+ Coverage 48.80% 53.04% +4.24%
==========================================
Files 90 125 +35
Lines 6276 11133 +4857
==========================================
+ Hits 3063 5906 +2843
- Misses 2528 4154 +1626
- Partials 685 1073 +388
Continue to review full report at Codecov.
|
|
It looks like this typo exists on master, so I'll retarget the PR for the |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, gallettilance, joelanford, Shivkumar13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change: Updated extract.go, got my eyes on this while reading the code.
Motivation for the change: Updating to have a good reading experience.
Reviewer Checklist
/docs