(.gitignore): Do not ignore debug/ #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anik120
force-pushed
the
validate-vu
branch
2 times, most recently
from
54ff55c to
c6aa007
Compare
anik120
force-pushed
the
validate-vu
branch
2 times, most recently
from
a9f9627 to
08fcac1
Compare
In PR operator-framework#888, there's vendoring of the cel-go package, one of which is named "debug" (github.com/google/cel-go/common/debug). Due to the .gitignore file ignoring all [Dd]bug folders, the vendored package isn't being checked in by git, causing the build to fail. This PR removes the instruction to ignore [Dd]bug/ folders. Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
=======================================
Coverage 52.06% 52.06%
=======================================
Files 103 103
Lines 9072 9072
=======================================
Hits 4723 4723
Misses 3441 3441
Partials 908 908 Continue to review full report at Codecov.
|
Member
Author
|
cc: @dinhxuanvu |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
In PR #888, there's vendoring of the cel-go package, one of which
is named "debug" (github.com/google/cel-go/common/debug). Due to
the .gitignore file ignoring all [Dd]bug folders, the vendored
package isn't being checked in by git, causing the build to fail.
This PR removes the instruction to ignore [Dd]bug/ folders.
Motivation for the change:
Reviewer Checklist
/docsOpen question to consider: Do we see foresee any drastic consequence of not ignoring all [Dd]ebug folders, apart from unwanted
debugfolders showing up in PRs ifgit add .is invoked? If we do, is an explicit!github.com/google/cel-go/common/debugbetter? Although that is hard-coding the package, and potentially confusing future vendoring efforts.