Skip to content

Conversation

@nsapse
Copy link
Contributor

@nsapse nsapse commented Jan 13, 2022

This commit bumps operator-framework/operator-registry requirement
go-sqlite3 from v1.10.0 to v1.14.10

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

Hi @nsapse. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2022
@openshift-ci openshift-ci bot requested review from estroz and timflannagan January 13, 2022 19:25
@timflannagan
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #896 (9eaa27d) into master (611525b) will not change coverage.
The diff coverage is n/a.

❗ Current head 9eaa27d differs from pull request most recent head 353058b. Consider uploading reports for the commit 353058b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         103      103           
  Lines        9092     9092           
=======================================
  Hits         4735     4735           
  Misses       3449     3449           
  Partials      908      908           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611525b...353058b. Read the comment docs.

@nsapse nsapse force-pushed the bump-go-sqlite3-v1-14-10 branch from 0f57e77 to 13e62fe Compare January 13, 2022 20:52
@dinhxuanvu
Copy link
Member

The title is misleading. You bump go-sqlite3 dependency, not operator-registry.

@nsapse nsapse changed the title (vendor) bump operator-registry to 1.14.10 (vendor) bump go-sqlite3 to 1.14.10 Jan 14, 2022
@nsapse
Copy link
Contributor Author

nsapse commented Jan 14, 2022

Good point - changed the PR title. My apologies.

@dinhxuanvu
Copy link
Member

The sanity check doesn't pass. Did you run make vendor?

@nsapse
Copy link
Contributor Author

nsapse commented Jan 14, 2022

Ran make vendor and re-submitted.

@dinhxuanvu
Copy link
Member

The merge commit shouldn't be there. You will need to do a proper rebase and squash those commits into a single one.

@nsapse nsapse force-pushed the bump-go-sqlite3-v1-14-10 branch from 9eaa27d to 0bc3536 Compare January 14, 2022 17:10
@nsapse
Copy link
Contributor Author

nsapse commented Jan 14, 2022

Rebased (hopefully properly)

@timflannagan
Copy link
Member

@nsapse Can we also update the commit message to reflect that we're bumping the go-sqlite3 dependency in this PR?

This commit bumps operator-framework/operator-registry requirement
go-sqlite3 from v1.10.0 to v1.14.10

Signed-off-by: Noah Sapse <nsapse@redhat.com>
@nsapse nsapse force-pushed the bump-go-sqlite3-v1-14-10 branch from 0bc3536 to 353058b Compare January 14, 2022 18:15
@nsapse
Copy link
Contributor Author

nsapse commented Jan 14, 2022

Updated

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, nsapse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4e3865a into operator-framework:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants