-
Notifications
You must be signed in to change notification settings - Fork 261
(vendor) bump go-sqlite3 to 1.14.10 #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(vendor) bump go-sqlite3 to 1.14.10 #896
Conversation
|
Hi @nsapse. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 52.07% 52.07%
=======================================
Files 103 103
Lines 9092 9092
=======================================
Hits 4735 4735
Misses 3449 3449
Partials 908 908 Continue to review full report at Codecov.
|
0f57e77 to
13e62fe
Compare
|
The title is misleading. You bump |
|
Good point - changed the PR title. My apologies. |
|
The sanity check doesn't pass. Did you run |
|
Ran make vendor and re-submitted. |
|
The merge commit shouldn't be there. You will need to do a proper rebase and squash those commits into a single one. |
9eaa27d to
0bc3536
Compare
|
Rebased (hopefully properly) |
|
@nsapse Can we also update the commit message to reflect that we're bumping the go-sqlite3 dependency in this PR? |
This commit bumps operator-framework/operator-registry requirement go-sqlite3 from v1.10.0 to v1.14.10 Signed-off-by: Noah Sapse <nsapse@redhat.com>
0bc3536 to
353058b
Compare
|
Updated |
dinhxuanvu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, nsapse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This commit bumps operator-framework/operator-registry requirement
go-sqlite3 from v1.10.0 to v1.14.10
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs