Skip to content

Conversation

@akihikokuroda
Copy link
Member

Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com

Description of the change:

Add Properties to Channel and Package blob for FBC. They are preserved for the alpha render command.
The unit tests in render_test.go and declcfg_to_model_test.go are updated are updated.

Motivation for the change:
Closes #895
Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
@openshift-ci openshift-ci bot requested review from awgreene and joelanford January 18, 2022 15:16
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #900 (c32e396) into master (c056ac1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         103      103           
  Lines        9092     9092           
=======================================
  Hits         4735     4735           
  Misses       3449     3449           
  Partials      908      908           
Impacted Files Coverage Δ
alpha/declcfg/declcfg.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c056ac1...c32e396. Read the comment docs.

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@cdjohnson
Copy link
Contributor

Built and tested against my own test catalog and it worked for me. Thanks!

@akihikokuroda
Copy link
Member Author

/assign @njhale

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5c3f4a3 into operator-framework:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FBC: Add properties to olm.package and olm.channel

6 participants