Add skip-tls-verify and use-http flag support to opm render #908

[ryanemerson]

#908

[openshift-ci]

Hi @ryanemerson. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[joelanford]

Thanks for the PR! Just a few minor suggestions...

[codecov]

Codecov Report

Merging #909 (4bfb402) into master (4e33928) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   52.18%   52.18%           
=======================================
  Files         103      103           
  Lines        9113     9113           
=======================================
  Hits         4756     4756           
  Misses       3451     3451           
  Partials      906      906           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e33928...4bfb402. Read the comment docs.

[joelanford]

/ok-to-test

[joelanford]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, ryanemerson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[phantomjinx]

Is this likely to be merged soon please?

[phantomjinx]

Is this likely to be merged soon please?

Hey @joelanford, do you have a timeframe for when this is going into a release please?

[kevinrizza]

/lgtm

[kevinrizza]

@phantomjinx usually we try to release minor versions of the registry on the same cadence as OLM releases, although our release process hasn't been the most consistent. our last release was only a few weeks ago, so my guess is it may be a little while until the next patch release. but if there's an urgent need for this patch, you could create an issue on this repository, tag this, and we can talk about cutting a release sooner in the upstream olm working group.

[ryanemerson]

@kevinrizza I have created #925. I have included details of Operatorhub changes that explain why a release is needed by April, thanks.