Skip to content

Conversation

@grokspawn
Copy link
Contributor

Description of the change:
Set me up to shoulder some of the blame for code I write. ;)

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from anik120 and kevinrizza May 18, 2022 15:46
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #955 (50ad1b0) into master (fd85a98) will not change coverage.
The diff coverage is n/a.

❗ Current head 50ad1b0 differs from pull request most recent head af0b0c6. Consider uploading reports for the commit af0b0c6 to get more accurate results

@@           Coverage Diff           @@
##           master     #955   +/-   ##
=======================================
  Coverage   52.42%   52.42%           
=======================================
  Files         103      103           
  Lines        9228     9228           
=======================================
  Hits         4838     4838           
  Misses       3468     3468           
  Partials      922      922           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd85a98...af0b0c6. Read the comment docs.

@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@grokspawn grokspawn merged commit 0b2f43f into master May 19, 2022
@grokspawn grokspawn deleted the lgtm-owner-entry branch August 19, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants