fix(diff): adds empty channel pruning with an include config on lates…

[jpower432]

…t mode

Fixes #957

Signed-off-by: Jennifer Power barnabei.jennifer@gmail.com

Description of the change:

This PR adds a fix and tests for opm alpha diff to ensure empty channels are pruned when heads-only is false.

Motivation for the change:
To fix a bug opm diff methods

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci]

Hi @jpower432. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #958 (6486cfe) into master (fd85a98) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   52.42%   52.42%   -0.01%     
==========================================
  Files         103      103              
  Lines        9228     9227       -1     
==========================================
- Hits         4838     4837       -1     
  Misses       3468     3468              
  Partials      922      922              

Impacted Files	Coverage Δ
alpha/declcfg/diff.go	80.80% <100.00%> (-0.08%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd85a98...6486cfe. Read the comment docs.

[dinhxuanvu]

/ok-to-test

[dinhxuanvu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, jpower432

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment