Skip to content

Add unit test to query_test to up coverage #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Add unit test to query_test to up coverage #983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions pkg/registry/query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
"testing"
"testing/fstest"

"github.com/operator-framework/operator-registry/alpha/model"
"github.com/operator-framework/operator-registry/alpha/property"
"github.com/stretchr/testify/require"

"github.com/operator-framework/operator-registry/alpha/declcfg"
Expand Down Expand Up @@ -196,6 +198,37 @@ func TestQuerier_ListPackages(t *testing.T) {
require.Equal(t, 2, len(packages))
}

func TestQuerier_BadBundleRaisesError(t *testing.T) {
t.Helper()

// Convert a good FS into a model
cfg, err := declcfg.LoadFS(validFS)
require.NoError(t, err)

m, err := declcfg.ConvertToModel(*cfg)
require.NoError(t, err)

// break the model by adding another package property
bundle := func() *model.Bundle {
for _, pkg := range m {
for _, ch := range pkg.Channels {
for _, bundle := range ch.Bundles {
return bundle
}
}
}
return nil
}()

bundle.Properties = append(bundle.Properties, property.Property{
Type: PackageType,
Value: []byte("{\"packageName\": \"another-package\", \"version\": \"1.0.0\"}"),
})

_, err = NewQuerier(m)
require.EqualError(t, err, "parse properties: expected exactly 1 property of type \"olm.package\", found 2")
}

func genTestModelQuerier(t *testing.T) *Querier {
t.Helper()

Expand Down