Skip to content

Conversation

@awgreene
Copy link
Member

@awgreene awgreene commented Jul 8, 2022

Problem: For some reason, a recent PR passed the Sanity check but master
has recorded that it fails the sanity check.

Solution: Update go dependencies

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Problem: For some reason, a recent PR passed the Sanity check but master
has recorded that it fails the sanity check.

Solution: Update go dependencies

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@openshift-ci openshift-ci bot requested review from hasbro17 and joelanford July 8, 2022 20:02
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #991 (49293cd) into master (0ceeecf) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   52.62%   52.63%   +0.01%     
==========================================
  Files         104      104              
  Lines        9422     9422              
==========================================
+ Hits         4958     4959       +1     
+ Misses       3535     3534       -1     
  Partials      929      929              
Impacted Files Coverage Δ
alpha/veneer/semver/semver.go 58.79% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ceeecf...49293cd. Read the comment docs.

@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@openshift-ci openshift-ci bot merged commit 8a159e8 into operator-framework:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants